| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | sulamul(at)gmail(dot)com |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, bossartn(at)amazon(dot)com, Jakub(dot)Wartak(at)tomtom(dot)com, matsumura(dot)ryo(at)fujitsu(dot)com, andres(at)anarazel(dot)de, masao(dot)fujii(at)oss(dot)nttdata(dot)com, mengjuan(dot)cmj(at)alibaba-inc(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-10-25 01:32:52 |
| Message-ID: | 20211025.103252.150817557361501738.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Fri, 22 Oct 2021 18:43:52 +0530, Amul Sul <sulamul(at)gmail(dot)com> wrote in
> Any thoughts about the patch posted previously?
Honestly, xlogreader looks fine with the current shape. The reason is
that it seems cleaner as an interface boundary since the caller of
xlogreader doesn't need to know about the details of xlogreader. The
current code nicely hides the end+1 confusion.
Even if we want to get rid of global variables in xlog.c, I don't
understand why we remove only abortedRecPtr. That change makes things
more complex as a whole by letting xlog.c be more conscious of
xlogreader's internals. I'm not sure I like that aspect of the patch.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-10-25 01:44:17 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Kyotaro Horiguchi | 2021-10-25 00:59:30 | Re: add retry mechanism for achieving recovery target before emitting FATA error "recovery ended before configured recovery target was reached" |