| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | 9erthalion6(at)gmail(dot)com |
| Cc: | x4mmm(at)yandex-team(dot)ru, stanhu(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: lastOverflowedXid does not handle transaction ID wraparound |
| Date: | 2021-10-21 04:01:40 |
| Message-ID: | 20211021.130140.12132472584596458.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 20 Oct 2021 13:48:33 +0200, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote in
> > On Wed, Oct 20, 2021 at 04:00:35PM +0500, Andrey Borodin wrote:
> > > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> написал(а):
> > > I wonder what would be side
> > > effects of clearing it when the snapshot is not suboverfloved anymore?
> >
> > I think we should just invalidate lastOverflowedXid on every XLOG_RUNNING_XACTS if subxid_overflow == false. I can't find a reason not to do so.
>
> From what I understand that was actually the case, lastOverflowedXid was
> set to InvalidTransactionId in ProcArrayApplyRecoveryInfo if
> subxid_overflow wasn't set. Looks like 10b7c686e52a6d1bb has changed it,
> to what I didn't pay attention originally.
Unfortunately(?), that doesn't happen once standbyState reaches
STANDBY_SNAPSHOT_READY.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-10-21 04:01:47 | Re: lastOverflowedXid does not handle transaction ID wraparound |
| Previous Message | Peter Smith | 2021-10-21 03:56:15 | Re: Data is copied twice when specifying both child and parent table in publication |