Re: Partition Check not updated when insert into a partition

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Partition Check not updated when insert into a partition
Date: 2021-10-18 17:40:31
Message-ID: 202110181740.qxd3qtox4xxa@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Oct-18, Alvaro Herrera wrote:

> Thanks. I'm looking at it now. I notice that if I take out the code
> fix and keep the tests, I only see the ATTACH side of the problem have a
> failure; I expected to see a failure for DETACH too.

Ah, no, the test covers both cases; it's just that if it fails the first
time, it'll fail to fail the second time. But if I run it separately,
and make it succeed the first time, then the second one will fail as
expected. This becomes better visible by adding \c in a few places, but
I don't think it's necessary to add it to the committed test -- I'm
taking the code as Amit submitted.

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Maybe there's lots of data loss but the records of data loss are also lost.
(Lincoln Yeoh)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-10-18 18:07:38 Re: BUG #17212: pg_amcheck fails on checking temporary relations
Previous Message Alvaro Herrera 2021-10-18 17:09:08 Re: Partition Check not updated when insert into a partition