From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: Running tests under valgrind is getting slower at an alarming pace |
Date: | 2021-10-07 02:03:02 |
Message-ID: | 20211007020302.t765uk6hqokqlmfu@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2021-10-06 09:47:54 -0700, Andres Freund wrote:
> I'll also try to figure out print a bit more detail about timing for each tap
> test, looks like I need to figure out how to pass PROVE_TEST='--timer' through
> the buildfarm. Shouldn't be too hard.
Turns out that the buildfarm already adds --timer. I added -j4 to allow for
some concurrency in tap tests, but unfortunately my animals fell over after
that (thanks Michael for noticing).
Looks like the buildfarm client code isn't careful enough quoting PROVE_FLAGS?
my $pflags = "PROVE_FLAGS=--timer";
if (exists $ENV{PROVE_FLAGS})
{
$pflags =
$ENV{PROVE_FLAGS}
? "PROVE_FLAGS=$ENV{PROVE_FLAGS}"
: "";
}
@makeout =
run_log("cd $dir && $make NO_LOCALE=1 $pflags $instflags $taptarget");
Which doesn't work if pflags ends up as '-j4 --timer' or such...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2021-10-07 02:18:24 | Re: strange case of "if ((a & b))" |
Previous Message | Michael Paquier | 2021-10-07 02:02:58 | Re: wrapping CF 2021-09 |