Re: [Patch] ALTER SYSTEM READ ONLY

From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Date: 2021-10-07 00:26:51
Message-ID: 20211007002651.GA20716@ahch-to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 05, 2021 at 04:11:58PM +0530, Amul Sul wrote:
> On Mon, Oct 4, 2021 at 1:57 PM Rushabh Lathia
> <rushabh(dot)lathia(at)gmail(dot)com> wrote:
> >
> > I tried to apply the patch on the master branch head and it's failing
> > with conflicts.
> >
>
> Thanks, Rushabh, for the quick check, I have attached a rebased version for the
> latest master head commit # f6b5d05ba9a.
>

Hi,

I got this error while executing "make check" on src/test/recovery:

"""
t/026_overwrite_contrecord.pl ........ 1/3 # poll_query_until timed out executing this query:
# SELECT '0/201D4D8'::pg_lsn <= pg_last_wal_replay_lsn()
# expecting this output:
# t
# last actual query output:
# f
# with stderr:
# Looks like your test exited with 29 just after 1.
t/026_overwrite_contrecord.pl ........ Dubious, test returned 29 (wstat 7424, 0x1d00)
Failed 2/3 subtests

Test Summary Report
-------------------
t/026_overwrite_contrecord.pl (Wstat: 7424 Tests: 1 Failed: 0)
Non-zero exit status: 29
Parse errors: Bad plan. You planned 3 tests but ran 1.
Files=26, Tests=279, 400 wallclock secs ( 0.27 usr 0.10 sys + 73.78 cusr 59.66 csys = 133.81 CPU)
Result: FAIL
make: *** [Makefile:23: check] Error 1
"""

--
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-07 00:41:23 Re: ALTER INDEX .. RENAME allows to rename tables/views as well
Previous Message Alvaro Herrera 2021-10-06 23:44:16 Re: ALTER INDEX .. RENAME allows to rename tables/views as well