| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Paul Guo <guopa(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Brown <michael(dot)brown(at)discourse(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: should frontend tools use syncfs() ? |
| Date: | 2021-10-02 15:41:54 |
| Message-ID: | 20211002154154.GD27491@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 30, 2021 at 05:08:24PM +1300, Thomas Munro wrote:
> On Thu, Sep 30, 2021 at 4:49 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > fsync_pgdata() is going to manipulate many inodes anyway, because
> > that's a code path designed to do so. If we know that syncfs() is
> > just going to be better, I'd rather just call it by default if
> > available and not add new switches to all the frontend tools in need
> > of flushing the data folder, switches that are not documented in your
> > patch.
>
> If we want this it should be an option, because it flushes out data
> other than the pgdata dir, and it doesn't report errors on old
> kernels.
I ran into bad performance of initdb --sync-only shortly after adding it to my
db migration script, so added initdb --syncfs.
I found that with sufficiently recent coreutils, I can do what's wanted by calling
/bin/sync -f /datadir
Since it's not integrated into initdb, it's necessary to include each
tablespace and wal.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2021-10-02 17:24:18 | Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified |
| Previous Message | Tom Lane | 2021-10-02 15:32:01 | Re: 2021-09 Commitfest |