Re: minor gripe about lax reloptions parsing for views

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor gripe about lax reloptions parsing for views
Date: 2021-10-01 13:15:27
Message-ID: 202110011315.gtcy62dvqyki@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Sep-30, Mark Dilger wrote:

> The solution is simple enough: stop using HEAP_RELOPT_NAMESPACES when
> parsing reloptions for views and instead create a
> VIEW_RELOPT_NAMESPACES array which does not include "toast".

It seems a reasonable (non-backpatchable) change to me.

> I've already fixed this, mixed into some other work. I'll pull it out
> as its own patch if there is any interest.


I suppose you'll need a new routine that returns the namespace array to
use based on relkind.

Álvaro Herrera PostgreSQL Developer —
"Nunca confiaré en un traidor. Ni siquiera si el traidor lo he creado yo"
(Barón Vladimir Harkonnen)

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-01 13:19:30 Re: proposal: possibility to read dumped table's name from file
Previous Message Tom Lane 2021-10-01 12:55:04 Re: fails on some timezones on windows