| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mengjuan(dot)cmj(at)alibaba-inc(dot)com" <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, "Jakub(dot)Wartak(at)tomtom(dot)com" <Jakub(dot)Wartak(at)tomtom(dot)com>, Ryo Matsumura <matsumura(dot)ryo(at)fujitsu(dot)com> |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-09-30 14:32:57 |
| Message-ID: | 202109301432.mou5kmj3h2r6@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Sep-30, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Regardless of this problem, I think we should simply call
> > set_replication_conf unconditionally in init(). Replication connections
> > are now allowed by default on Unix, this would just bring Windows nodes
> > into line with that.
>
> Yeah, I was thinking along the same lines yesterday. The fact that
> pre-commit testing failed to note the problem is exactly because we
> have this random difference between what works by default on Unix
> and what works by default on Windows. Let's close that gap before
> it bites us again.
+1
> There's still the issue of these tests overriding postgresql.conf
> entries made by init(), but maybe we can live with that?
I vote to at least have has_archiving=>1 set wal_level=replica, and
potentially max_wal_senders=2 too (allows pg_basebackup).
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2021-09-30 14:44:45 | PQcancel does not use tcp_user_timeout, connect_timeout and keepalive settings |
| Previous Message | Tom Lane | 2021-09-30 14:28:32 | Re: prevent immature WAL streaming |