Re: Evaluate expression at planning time for two more cases

From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>
Subject: Re: Evaluate expression at planning time for two more cases
Date: 2021-09-27 00:52:09
Message-ID: 20210927005209.GA26132@ahch-to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jul 06, 2021 at 01:09:56PM +1200, David Rowley wrote:
> On Tue, 9 Mar 2021 at 05:13, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> > It was a minor change therefore I rebased the patch, please take a look.
> This is not really an acceptable way to determine the notnull
> attribute value. Andy Fan proposes a much better way in [1].
> RelOptInfo is meant to cache the required Relation data that we need
> during query planning. IIRC, Andy's patch correctly uses this and does
> so in an efficient way.
> In any case, as you can see there's a bit of other work going on to
> smarten up the planner around NULL value detection. The UniqueKeys
> patch requires this and various other things have come up that really
> should be solved.
> Surafel, I'd suggest we return this patch with feedback and maybe you
> could instead help reviewing the other patches in regards to the NOT
> NULL tracking and maybe come back to this once the dust has settled
> and everyone is clear on how we determine if a column is NULL or not.
> Let me know your thoughts.

Hi Surafel,

We haven't seen an answer from you on this.
I'm marking the patch as "Returned with feedback" as was suggested.

Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2021-09-27 01:07:13 Re: PG 14 release notes, first draft
Previous Message Masahiko Sawada 2021-09-27 00:50:53 Re: Skipping logical replication transactions on subscriber side