Re: Improve logging when using Huge Pages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pryzby(at)telsasoft(dot)com
Cc: masao(dot)fujii(at)oss(dot)nttdata(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: Improve logging when using Huge Pages
Date: 2021-09-27 02:40:23
Message-ID: 20210927.114023.1519840069762071193.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 21 Sep 2021 19:23:22 -0500, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote in
> On Wed, Sep 22, 2021 at 02:03:11AM +0900, Fujii Masao wrote:
> > Another idea is to output "Anonymous shared memory was allocated with
> > huge pages" when it's successfully allocated with huge pages, and to output
> > "Anonymous shared memory was allocated without huge pages"
> > when it's successfully allocated without huge pages. I'm not sure if users
> > may think even this message is noisy, though.
>
> +1

+1. Positive phrase looks better.

> Maybe it could show the page size instead of "with"/without:
> "Shared memory allocated with 4k/1MB/1GB pages."

+1.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-09-27 03:17:37 Re: decoupling table and index vacuum
Previous Message David E. Wheeler 2021-09-27 02:38:46 Re: When is int32 not an int32?