| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Subject: | Re: postgres.h included from relcache.h - but removing it breaks pg_upgrade |
| Date: | 2021-09-18 20:35:22 |
| Message-ID: | 202109182035.ls55i32hwvta@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Sep-18, Alexander Korotkov wrote:
> I see now. I think I'm rather favoring splitting visibilitymap.h.
Agreed, this looks sane to me. However, I think the
VM_ALL_{VISIBLE,FROZEN} macros should remain in visibilitymap.h, since
they depend on the visibilitymap_get_status function (and pg_upgrade
doesn't use them).
There's a typo "maros" for "macros" in the new header file. (Also, why
does the copyright line say "portions" if no portion under another
copyright? I think we don't say "portions" when there is only one
copyright statement line.)
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-09-18 20:46:05 | Re: PG 14 release notes, first draft |
| Previous Message | Alvaro Herrera | 2021-09-18 20:19:04 | Re: Timeout failure in 019_replslot_limit.pl |