Re: Estimating HugePages Requirements?

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, andres(at)anarazel(dot)de, magnus(at)hagander(dot)net, mark(dot)dilger(at)enterprisedb(dot)com, don(at)seiler(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Estimating HugePages Requirements?
Date: 2021-09-16 17:14:27
Message-ID: 20210916171427.GR831@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers


+ * and the hugepage-related mmap flags to use into *mmap_flags. If huge pages
+ * is not supported, *hugepagesize and *mmap_flags will be set to 0.

nitpick: *are* not supported, as you say elsewhere.

+ gettext_noop("Shows the number of huge pages needed for the main shared memory area."),

Maybe this was already discussed, but "main" could be misleading.

To me that sounds like there might be huge pages needed for something other
than the "main" area and the reported value might turn out to be inadequate,
(which is exactly the issue these patch are trying to address).

In particular, this sounds like it's just going to report
shared_buffers/huge_page_size (since shared buffers is usually the "main" use
of shared memory) - rather than reporting the size of the entire shared memory
in units of huge_pages.

--
Justin

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message Bossart, Nathan 2021-09-16 21:26:56 Re: Estimating HugePages Requirements?
Previous Message Bossart, Nathan 2021-09-16 17:06:11 Re: Estimating HugePages Requirements?

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Joseph Krogh 2021-09-16 17:29:14 Re: EXPLAIN(VERBOSE) to CTE with SEARCH BREADTH FIRST fails
Previous Message Bossart, Nathan 2021-09-16 17:06:11 Re: Estimating HugePages Requirements?