Re: prevent immature WAL streaming

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: masao(dot)fujii(at)oss(dot)nttdata(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)lists(dot)postgresql(dot)org, bossartn(at)amazon(dot)com, mengjuan(dot)cmj(at)alibaba-inc(dot)com, Jakub(dot)Wartak(at)tomtom(dot)com
Subject: Re: prevent immature WAL streaming
Date: 2021-09-04 00:03:45
Message-ID: 202109040003.mrmrswfamedu@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Sep-03, Alvaro Herrera wrote:

> I thought that the way to have debug output for this new WAL code is to
> use WAL_DEBUG; that way it won't bother anyone and we can remove them
> later if necessary.
> Also, I realized that we should cause any error in the path that
> assembles a record from contrecords is to set a flag that we can test
> after the standard "err:" label; no need to create a new label.
> I also wrote a lot more comments to try and explain what is going on and
> why.
> I'm still unsure about the two-flags reporting in xlogreader, so I put
> that in a separate commit. Opinions on that one?
> The last commit is something I noticed in pg_rewind ...

Oh, the pg_rewind tests died. I fat-fingered the Assert conversion.

Álvaro Herrera PostgreSQL Developer —

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-09-04 00:04:31 Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead
Previous Message Alvaro Herrera 2021-09-04 00:01:50 Re: prevent immature WAL streaming