From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | bossartn(at)amazon(dot)com |
Cc: | magnus(at)hagander(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Read-only vs read only vs readonly |
Date: | 2021-09-03 06:10:00 |
Message-ID: | 20210903.151000.1059783435784417026.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Thu, 2 Sep 2021 22:07:02 +0000, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote in
> On 9/2/21, 11:30 AM, "Magnus Hagander" <magnus(at)hagander(dot)net> wrote:
> > I had a customer point out to me that we're inconsistent in how we
> > spell read-only. Turns out we're not as inconsistent as I initially
> > thought :), but that they did manage to spot the one actual log
> > message we have that writes it differently than everything else -- but
> > that broke their grepping...
> >
> > Almost everywhere we use read-only. Attached patch changes the one log
> > message where we didn't, as well as a few places in the docs for it. I
> > did not bother with things like comments in the code.
> >
> > Two questions:
> >
> > 1. Is it worth fixing? Or just silly nitpicking?
>
> It seems entirely reasonable to me to consistently use "read-only" in
> the log messages and documentation.
>
> > 2. What about translations? This string exists in translations --
> > should we just "fix" it there, without touching the translated string?
> > Or try to fix both? Or leave it for the translators who will get a
> > diff on it?
>
> I don't have a strong opinion, but if I had to choose, I would say to
> leave it to the translators to decide.
+1 for both. As a translator, it seems that that kind of changes are
usual. Many changes about full-stops, spacings, capitalizing and so
happen especially at near-release season like now.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Shinoda, Noriyoshi (PN Japan FSIP) | 2021-09-03 06:28:58 | RE: Improve logging when using Huge Pages |
Previous Message | kuroda.hayato@fujitsu.com | 2021-09-03 05:56:21 | RE: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name) |