| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | vignesh21(at)gmail(dot)com |
| Cc: | houzj(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Added missing invalidations for all tables publication |
| Date: | 2021-08-31 08:30:06 |
| Message-ID: | 20210831.173006.2232867434123922765.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Tue, 31 Aug 2021 08:31:05 +0530, vignesh C <vignesh21(at)gmail(dot)com> wrote in
> On Tue, Aug 31, 2021 at 7:40 AM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> Thanks for the comment, I have slightly modified the test case which
> will fail without the patch. Attached v2 patch which has the changes
> for the same.
The test works fine. The code looks fine for me except one minor
cosmetic flaw.
+ if (!HeapTupleIsValid(tup))
+ elog(ERROR, "cache lookup failed for publication %u",
+ pubid);
The last two lines don't need to be separated. ((Almost) All other
instance of the same error is written that way.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2021-08-31 08:36:48 | Re: [PATCH] Tab completion for ALTER TABLE … ADD … |
| Previous Message | Denis Hirn | 2021-08-31 08:16:47 | Re: [PATCH] Allow multiple recursive self-references |