Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified
Date: 2021-08-30 20:51:27
Message-ID: 202108302051.7ernwkr66lx7@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Aug-13, David Christensen wrote:

> Both bugs #16676[1] and #17141[2] illustrate that the combination of
> SKIP LOCKED and FETCH FIRST WITH TIES break expectations when it comes
> to rows returned to other sessions accessing the same row. Since this
> situation is detectable from the syntax and hard to fix otherwise,
> forbid for now, with the potential to fix in the future.

I think we should do this, given that it has show potential to bite
people. We should also add a small mentioned to this in the docs, as in
the attached.

What do others think?

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Escucha y olvidarás; ve y recordarás; haz y entenderás" (Confucio)

Attachment Content-Type Size
ties-no-skip.patch text/x-diff 818 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Christensen 2021-08-30 20:55:10 Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified
Previous Message Alvaro Herrera 2021-08-30 20:31:51 Re: reporting TID/table with corruption error