Re: extended stats objects are the only thing written like "%s"."%s"

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: extended stats objects are the only thing written like "%s"."%s"
Date: 2021-08-30 18:06:02
Message-ID: 202108301806.uptgzo2viv6p@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Aug-28, Tom Lane wrote:

> I think what we are doing there is following the message style
> guideline that says to put double quotes around inserted strings.
> In this case schema.object (as a whole) is the inserted string.
> People often confuse this with SQL double-quoted identifiers, but it
> has nothing whatsoever to do with SQL's rules. (It's easier to make
> sense of this rule in translations where the quote marks are not
> ASCII double-quotes ... like your example with «nice».)
>
> In short: Justin is right, this should not be done this way.

I don't agree with the way we're applying the message guidelines here,
but since this is the only place where we do this, I've changed it to
the idiomatic way of quoting names.

I only backpatched to 14 in order to avoid messing with established
output format in released branches, but if people really hate the extra
quotes with a passion I'm not opposed to backpatching further.

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"World domination is proceeding according to plan" (Andrew Morton)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-08-30 18:27:09 Re: perlcritic: prohibit map and grep in void conext
Previous Message Tom Lane 2021-08-30 17:33:42 Re: Can we get rid of repeated queries from pg_dump?