Re: pg_dump, ATTACH, and independently restorable child partitions

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_dump, ATTACH, and independently restorable child partitions
Date: 2021-08-30 15:42:49
Message-ID: 20210830154249.GX26465@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 25, 2020 at 06:35:19PM -0500, Tom Lane wrote:
> What we'd need to do if we want this to work with direct-to-DB restore
> is to split off the ATTACH PARTITION command as a separate TOC entry.
> That doesn't seem amazingly difficult, and it would even offer the
> possibility that you could extract the partition standalone without
> having to ignore errors. (You'd use -l/-L to select the CREATE TABLE,
> the data, etc, but not the ATTACH object.)

On Mon, Jan 11, 2021 at 09:28:18PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > [ v5-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ]
>
> Pushed with mostly cosmetic edits.

Thanks for pushing (9a4c0e36f).

Should this be included in the release notes ?

It's a user-visible change visible in pg_restore -l. Someone might be
surprised that the attach "object" needs to be included for restore -L to
behave the same as it use to.

--
-- Name: cdrs_2021_08_22; Type: TABLE ATTACH; Schema: child; Owner: telsasoft
--

7949; 1259 1635139558 TABLE child cdrs_2021_08_24 telsasoft
62164; 0 0 TABLE ATTACH child cdrs_2021_08_24 telsasoft
; depends on: 7949

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-08-30 15:59:50 Re: Use extended statistics to estimate (Var op Var) clauses
Previous Message REIX, Tony 2021-08-30 15:35:23 RE: AIX: Symbols are missing in libpq.a