| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-29 02:37:22 |
| Message-ID: | 20210829023722.cz6nbehyupp3hemk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-08-23 15:55:03 -0400, alvherre(at)alvh(dot)no-ip(dot)org wrote:
> On 2021-Aug-23, Bossart, Nathan wrote:
>
> > Ah, okay. BTW the other changes you mentioned made sense to me.
>
> Thanks. I've pushed this now to all live branches.
While rebasing the aio patchset ontop of HEAD I noticed that this commit added
another atomic operation to XLogWrite() with archiving enabled. The WAL write
path is really quite hot, and at least some of the
NotifySegmentsReadyForArchive() calls are done while WALWriteLock is held.
I think we should at least try to make the fast-path where no segment
boundaries were crossed use no atomic operations.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Himanshu Upadhyaya | 2021-08-29 08:06:56 | inconsistent behavior with "GENERATED BY DEFAULT AS IDENTITY" |
| Previous Message | vignesh C | 2021-08-29 01:51:57 | Re: Added schema level support for publication. |