Re: Can we get rid of repeated queries from pg_dump?

From: hubert depesz lubaczewski <depesz(at)depesz(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: Can we get rid of repeated queries from pg_dump?
Date: 2021-08-28 06:46:50
Message-ID: 20210828064650.GB11579@depesz.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Fri, Aug 27, 2021 at 05:23:23PM -0400, Tom Lane wrote:
> Those queries are coming from getFormattedTypeName(), which is used
> for function arguments and the like. I'm not quite sure why Hubert
> is seeing 5000 such calls in a database with only ~100 functions;
> surely they don't all have an average of 50 arguments?

Oh. missed that part.
So I checked. In the mean time I got -Fc dump, so:

#v+
=$ pg_restore -l schema.dump | \
grep -P '^\d*; \d+ \d+ FUNCTION ' |
sed 's/^[^(]*(//; s/)[^)]*$//' |
awk -F, '{print NF}' |
sort -n |
uniq -c
23 0
52 1
21 2
8 3
1 4
2 5
#v-

23 functions with 0 arguments, 52 with 1, and the max is 5 arguments - two
functions have these.

Not sure if it matters but there is a lot of enums. 83 of them. And they have
up to 250 elements (2 such types).

Best regards,

depesz

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Justin Pryzby 2021-08-28 13:01:39 Re: Supported RHEL version for PostgreSQL 11
Previous Message hubert depesz lubaczewski 2021-08-28 06:38:24 Re: Can we get rid of repeated queries from pg_dump?

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-08-28 07:10:39 Re: Gather performance analysis
Previous Message hubert depesz lubaczewski 2021-08-28 06:38:24 Re: Can we get rid of repeated queries from pg_dump?