| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |
| Date: | 2021-08-12 12:54:21 |
| Message-ID: | 20210812125421.qwfa7tganpp674mc@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2021-08-12 05:48:19 -0700, Andres Freund wrote:
> I think SharedFileSetInit() needs a comment explaining that it needs to be
> called in a process-lifetime memory context if used without dsm
> segments. Because otherwise SharedFileSetDeleteOnProcExit() will access
> already freed memory (both for filesetlist and the SharedFileSet itself).
Oh. And I think it's not ok that SharedFileSetDeleteAll() unconditionally does
SharedFileSetUnregister(). SharedFileSetUnregister() asserts out if there's no
match, but DSM based sets are never entered into filesetlist. So one cannot
have a non-DSM and DSM set coexisting. Which seems surprising.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-08-12 12:55:11 | pgsql: Fix grammar mistake in hash index README |
| Previous Message | Andres Freund | 2021-08-12 12:48:19 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-08-12 12:55:29 | Re: Grammar fix in hash index README |
| Previous Message | Andres Freund | 2021-08-12 12:48:19 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |