Re: archive status ".ready" files may be created too early

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: bossartn(at)amazon(dot)com
Cc: alvherre(at)alvh(dot)no-ip(dot)org, x4mmm(at)yandex-team(dot)ru, a(dot)lubennikova(at)postgrespro(dot)ru, hlinnaka(at)iki(dot)fi, matsumura(dot)ryo(at)fujitsu(dot)com, masao(dot)fujii(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: archive status ".ready" files may be created too early
Date: 2021-08-05 04:04:20
Message-ID: 20210805.130420.22317944693814351.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

By the way about the v3 patch,

+#define InvalidXLogSegNo ((XLogSegNo) 0xFFFFFFFFFFFFFFFF)

Like InvalidXLogRecPtr, the first valid segment number is 1 so we can
use 0 as InvalidXLogSegNo.

BootStrapXLOG():
/* Create first XLOG segment file */
openLogFile = XLogFileInit(1);

KeepLogSeg():
/* avoid underflow, don't go below 1 */
if (currSegNo <= keep_segs)
segno = 1;

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2021-08-05 04:18:51 Re: Sort keys are omitted incorrectly after grouping sets
Previous Message Yugo NAGATA 2021-08-05 03:41:09 Re: Implementing Incremental View Maintenance