Re: Rename of triggers for partitioned tables

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Arne Roland <A(dot)Roland(at)index(dot)de>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rename of triggers for partitioned tables
Date: 2021-07-22 17:33:10
Message-ID: 202107221733.lnopatzhx3zt@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Jul-22, Arne Roland wrote:

> Since it is sort of the same problem, I think it might be worthwhile
> to address it as well within this patch. Adding two to four ereports
> doesn't sound like scope creeping to me, even though it touches
> completely different code. I'll look into that as well.

I don't understand what you mean. But here's an updated patch, with the
following changes

1. support for ONLY is removed, since evidently the only thing it is
good for is introduce inconsistencies

2. recursion to partitioned tables always occurs; no more conditionally
on relation->inh. This is sensible because due to point 1 above, inh
can no longer be false.

3. renaming a trigger that's not topmost is forbidden.

Álvaro Herrera 39°49'30"S 73°17'W —

Attachment Content-Type Size
v10-0001-Make-ALTER-TRIGGER-RENAME-consistent-for-partiti.patch text/x-diff 16.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-07-22 17:41:33 Re: Rename of triggers for partitioned tables
Previous Message Mark Dilger 2021-07-22 17:29:13 Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)