| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Column Filtering in Logical Replication |
| Date: | 2021-07-12 14:53:01 |
| Message-ID: | 202107121453.fnxj3xee3jkp@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jul-12, Tomas Vondra wrote:
> FWIW "make check" fails for me with this version, due to segfault in
> OpenTableLists. Apparenly there's some confusion - the code expects the
> list to contain PublicationTable nodes, and tries to extract the
> RangeVar from the elements. But the list actually contains RangeVar, so
> this crashes and burns. See the attached backtrace.
>
> I'd bet this is because the patch uses list of RangeVar in some cases
> and list of PublicationTable in some cases, similarly to the "row
> filtering" patch nearby. IMHO this is just confusing and we should
> always pass list of PublicationTable nodes.
+1 don't make the code guess what type of list it is. Changing all the
uses of that node to deal with PublicationTable seems best.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Cuando no hay humildad las personas se degradan" (A. Christie)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gkokolatos | 2021-07-12 15:01:16 | Re: Introduce pg_receivewal gzip compression tests |
| Previous Message | Matthias van de Meent | 2021-07-12 14:30:41 | Re: ATTACH PARTITION locking documentation for DEFAULT partitions |