Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: coelho(at)cri(dot)ensmp(dot)fr, thomas(dot)munro(at)gmail(dot)com, m(dot)polyakova(at)postgrespro(dot)ru, alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, teodor(at)sigaev(dot)ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Date: 2021-07-05 09:11:51
Message-ID: 20210705181151.716d3705f42cfe3f5c7315cb@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Ishii-san,

On Thu, 01 Jul 2021 09:03:42 +0900 (JST)
Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:

> > v13 patches gave a compiler warning...
> >
> > $ make >/dev/null
> > pgbench.c: In function ‘commandError’:
> > pgbench.c:3071:17: warning: unused variable ‘command’ [-Wunused-variable]
> > const Command *command = sql_script[st->use_file].commands[st->command];
> > ^~~~~~~

Hmm, we'll get the warning when --enable-cassert is not specified.
I'll fix it.

> There is a typo in the doc (more over -> moreover).
>
> > of all transaction tries; more over, you cannot use an unlimited number
>
> of all transaction tries; moreover, you cannot use an unlimited number
>

Thanks. I'll fix.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2021-07-05 09:44:11 Re: Numeric multiplication overflow errors
Previous Message Andrey Borodin 2021-07-05 08:50:19 Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)