| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Subject: | Re: Partitioned index can be not dumped |
| Date: | 2021-07-01 17:01:19 |
| Message-ID: | 202107011701.b5x3e7scf6tp@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-30, Alexander Pyhalov wrote:
> Looks good. It seems this comment refers to line 455.
Ah, so it does.
I realized that we don't need to do vac_open_indexes for partitioned
tables: it is sufficient to know whether there are any indexes at all.
So I replaced that with RelationGetIndexList() and checking if the list
is nonempty, specifically for the partitioned table case. Pushed now.
Thanks for reporting and fixing this, and to Zhihong Yu for reviewing.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-07-01 17:03:00 | Re: Reducing the cycle time for CLOBBER_CACHE_ALWAYS buildfarm members |
| Previous Message | Tom Lane | 2021-07-01 16:57:38 | Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE |