Re: Partitioned index can be not dumped

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Partitioned index can be not dumped
Date: 2021-06-30 21:57:36
Message-ID: 202106302157.dh4gl7tu2v2x@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jun-30, Zhihong Yu wrote:

> Hi,
> In that case, I wonder whether nindexes can be negated following the call
> to vac_open_indexes().
>
> vac_open_indexes(onerel, AccessShareLock, &nindexes, &Irel);
> + nindexes = -nindexes;
>
> That way, hasindex can be dropped.
> vac_update_relstats() call would become:
>
> vac_update_relstats(onerel, -1, totalrows,
> - 0, false, InvalidTransactionId,
> + 0, nindexes != 0, InvalidTransactionId,

Perhaps this works, but I don't think it's a readability improvement.

> My thinking is that without hasindex, the code is easier to maintain.

You have one less variable but one additional concept (negative
nindexes). It doesn't seem easier to me, TBH, rather the opposite.

--
Álvaro Herrera 39°49'30"S 73°17'W
https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-06-30 22:20:14 Re: PG 14 release notes, first draft
Previous Message Zhihong Yu 2021-06-30 21:56:17 Re: Partitioned index can be not dumped