Re: Maintaining a list of pgindent commits for "git blame" to ignore

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore
Date: 2021-06-23 00:00:55
Message-ID: 202106230000.4cfnjbp25o3k@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Mar-18, Peter Geoghegan wrote:

> On Thu, Mar 18, 2021 at 3:12 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > It would be kind of nice if the file can be generated automatically. I
> > have you checked if 'pgindent' being on the first line of the commit is
> > sufficient?
>
> I generated the file by looking for commits that:
>
> 1) Mentioned "pgindent" or "PGINDENT" in the entire commit message.
>
> 2) Had more than 20 or 30 files changed.

Is there a minimum git version for this to work? It doesn't seem to
work for me.

... ah, apparently one needs git 2.23:
https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame

I have 2.20.

[ apt install -t buster-backports git ]

I have 2.30. It works better. To be clear: some lines still appear as
originating in some pgindent commit, when they are created by such a
commit. But as far as I've seen, they're mostly uninteresting ones
(whitespace, only braces, only "else", only "for (;;)" and similar).

The git blame experience seems much better. Thanks!

--
Álvaro Herrera 39°49'30"S 73°17'W
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2021-06-23 00:11:41 Re: Maintaining a list of pgindent commits for "git blame" to ignore
Previous Message Michael Paquier 2021-06-22 23:46:12 Re: cleanup temporary files after crash