From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Centralizing protective copying of utility statements |
Date: | 2021-06-17 18:00:55 |
Message-ID: | 20210617180055.txf7g6tkelk2f2x4@nol |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 17, 2021 at 01:03:29PM -0400, Tom Lane wrote:
>
> Here's a v2 that does it like that. In this formulation, we're
> basically hoisting the responsibility for doing copyObject up into
> ProcessUtility from its direct children, which seems like a clearer
> way of thinking about what has to change.
I agree that forcing an API break is better. Just a nit:
+ * readOnlyTree: treat pstmt's node tree as read-only
Maybe it's because I'm not a native english speaker, or because it's quite
late here, but I don't find "treat as read-only" really clear. I don't have a
concise better wording to suggest.
> Still thinking about which way to fix it in the back branches.
I'm +0.5 for a narrow fix, due to the possibility of unspotted similar problem
vs possibility of performance regression ratio.
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-06-17 18:03:18 | Re: Add version macro to libpq-fe.h |
Previous Message | Robert Haas | 2021-06-17 17:53:38 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |