| From: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, rulyox(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error on pgbench logs |
| Date: | 2021-06-15 12:31:40 |
| Message-ID: | 20210615213140.8e84c8d211e6d6a2241c41c6@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 15 Jun 2021 18:01:18 +0900
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jun 15, 2021 at 05:15:14PM +0900, Yugo NAGATA wrote:
> > On Tue, 15 Jun 2021 10:05:29 +0200 (CEST) Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > It was not a problem because --sampling-rate --aggregate-interval cannot be
> > used at the same time.
>
> Yep, you are right, thanks. I have missed that both options cannot be
> specified at the same time.
Maybe, adding Assert(sample_rate == 0.0 || agg_interval == 0) or moving
the check of sample_rate into the else block could improve code readability?
--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-06-15 12:41:23 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Previous Message | Robert Haas | 2021-06-15 12:19:02 | Re: Race condition in recovery? |