From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Muhammad Usama <m(dot)usama(at)gmail(dot)com> |
Subject: | Re: A new function to wait for the backend exit after termination |
Date: | 2021-06-15 00:40:40 |
Message-ID: | 20210615004040.GA914731@rfd.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 14, 2021 at 07:34:59PM +0530, Bharath Rupireddy wrote:
> Thanks. +1 to remove the pg_wait_for_backend_termination function. The
> patch basically looks good to me. I'm attaching an updated patch. I
> corrected a minor typo in the commit message, took docs and code
> comment changes suggested by Justin Pryzby.
Pushed as two commits. I used your log message typo fix. Here were the diffs
in your v2 and not in an earlier patch:
> -+ Add an optional wait parameter to <link
> ++ Add an optional timeout parameter to <link
I used this.
> -+ int timeout; /* milliseconds */
> ++ int timeout; /* milliseconds */
pgindent chooses a third option, so I ran pgindent instead of using this.
> Please note that release notes still have the headline "Add functions
> to wait for backend termination" of the original commit that added the
> pg_wait_for_backend_termination. With the removal of it, I'm not quite
> sure if we retain the the commit message or tweak it to something like
> "Add optional timeout parameter to pg_terminate_backend".
> <!--
> Author: Magnus Hagander <magnus(at)hagander(dot)net>
> 2021-04-08 [aaf043257] Add functions to wait for backend termination
> -->
That part is supposed to mirror "git log --pretty=format:%s", no matter what
happens later. The next set of release note updates might add my latest
commit (5f1df62) to this SGML comment, on another line.
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2021-06-15 00:43:18 | Re: Skipping logical replication transactions on subscriber side |
Previous Message | Michael Paquier | 2021-06-15 00:23:21 | Re: Teaching users how they can get the most out of HOT in Postgres 14 |