Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`

From: Andres Freund <andres(at)anarazel(dot)de>
To: 盏一 <w(at)hidva(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`
Date: 2021-06-12 04:42:55
Message-ID: 20210612044255.bcx5odehulatnxgq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-05-07 04:36:25 +0800, 盏一 wrote:
> &gt;&nbsp;Sounds like a plan! Do you want to write a patch?
> Add the patch.

Thanks for the patch. I finally pushed an edited version of it. There
were other loops over ->pgprocnos, so I put assertions in those - that
gains us a a good bit more checking than we had before...

I also couldn't resist to do some small formatting cleanups - I found
the memmove calls just too hard to read.

I took the authorship information as you had it in the diff you attached
- I hope that's OK?

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 盏一 2021-06-12 04:52:13 Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()`
Previous Message Noah Misch 2021-06-12 04:37:50 Re: A new function to wait for the backend exit after termination