| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, iwata(dot)aya(at)fujitsu(dot)com, tsunakawa(dot)takay(at)fujitsu(dot)com, k(dot)jamison(at)fujitsu(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq debug log |
| Date: | 2021-06-11 05:00:20 |
| Message-ID: | 20210611050020.GB573364@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 07, 2021 at 11:37:58AM -0400, Robert Haas wrote:
> On Sat, Jun 5, 2021 at 11:03 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > > This added a PQtraceSetFlags() function. We have a dozen PQset*() functions,
> > > but this and PQresultSetInstanceData() are the only PQSomethingSet()
> > > functions. Is it okay if I rename it to PQsetTraceFlags()? I think that
> > > would be more idiomatic for libpq.
> >
> > Hmm, there is an obvious parallel between PQtrace() and
> > PQtraceSetFlags() which is lost with your proposed rename. I'm not
> > wedded to the name though, so I'm just -0.1 on the rename. If you feel
> > strongly about it, I won't oppose it.
>
> I'm +1 for the rename. I think it's a lot more idiomatic.
At +1 vs. -0.1, I would have withdrawn the proposal. Seeing +2 vs. -0.1, I
have pushed it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-06-11 05:07:45 | Re: Race condition in recovery? |
| Previous Message | Noah Misch | 2021-06-11 04:55:46 | Re: PoC/WIP: Extended statistics on expressions |