Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date: 2021-05-26 23:44:03
Message-ID: 202105262344.uo3thib7lpml@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-May-26, Tom Lane wrote:

> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:

> > It would be good to have a test case in src/bin/pg_dump/t/
> > for the case
> Personally I won't touch with a 10-foot pole, but if
> somebody else wants to, have at it.


> > ... and I find it odd that we don't seem to have anything
> > for the "CREATE TABLE foo (LIKE sometab INCLUDING stuff)" form of the
> > command ... but neither of those seem the fault of this patch, and they
> > both work as [I think] is intended.
> Hm, there's this in compression.sql:
> \d+ cmdata2
> Or did you mean the case with a partitioned table specifically?

Ah, I guess that's sufficient. (The INCLUDING clause cannot be used to
create a partition, actually.)

Álvaro Herrera 39°49'30"S 73°17'W
"Now I have my system running, not a byte was off the shelf;
It rarely breaks and when it does I fix the code myself.
It's stable, clean and elegant, and lightning fast as well,
And it doesn't cost a nickel, so Bill Gates can go to hell."

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-05-26 23:46:29 Re: storing an explicit nonce
Previous Message Andres Freund 2021-05-26 23:26:01 Re: storing an explicit nonce