Re: PG 14 release notes, first draft

On Wed, May 19, 2021 at 09:39:08AM -0500, Justin Pryzby wrote:
> These sound weird since markup was added in 6a5bde7d4:
> https://www.postgresql.org/docs/devel/release-14.html
> | Remove server and Chapter 34 support for the version 2 wire protocol (Heikki Linnakangas)
> ...
> | Pass doubled quote marks in Chapter 36 SQL command strings literally (Tom Lane)

> -Remove server and libpq support for the version 2 wire protocol (Heikki Linnakangas)
> +Remove server and <xref linkend="libpq"/> support for the version 2 <link linkend="protocol">wire protocol</link> (Heikki Linnakangas)

Agreed, fixed.

> > Force custom server variable names to match the pattern used for unquoted SQL identifiers (Tom Lane)
> Say "Require" not force?

Agreed, fixed.

> > This setting was disabled in PostgreSQL version 13.3.
> "disabled" sounds like it was set to "off". Maybe say it was ignored.

OK, I went with this:

This setting was ignored starting in
<productname>PostgreSQL</productname> version 13.3.

> > Add long-running queries to be canceled if the client disconnects (Sergey Cherkashin, Thomas Munro)
> Should say: Allow

Yes.

> > The server variable client_connection_check_interval allows supporting operating systems, e.g., Linux, to automatically cancel queries by disconnected clients.
> say "some operating systems" ?

Agreed, done.

> > This can be disabled by turning client option "sslsni" off.
> "turning off"

Agreed.

> | Add %P to log_line_prefix to report the parallel group leader (Justin Pryzby)
>
> Maybe it should say "Allow %P in log_line_prefix to ...", otherwise it sounds
> like the default was changed.

I am not sure, but I changed it as you suggested:

Allow %P in <varname>log_line_prefix</varname> to report the
parallel group leader (Justin Pryzby)

> | Reduce the default value of vacuum_cost_page_miss (Peter Geoghegan)
> | This new default better reflects current hardware capabilities.
> Also say: the previous default was 10.

Uh, we didn't report the new value, so why report the old one?

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.