Re: Multiple pg_waldump --rmgr options

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: rjuju123(at)gmail(dot)com
Cc: hlinnaka(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Multiple pg_waldump --rmgr options
Date: 2021-05-19 02:50:52
Message-ID: 20210519.115052.172967766943710360.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 18 May 2021 23:23:02 +0800, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote in
> On Tue, May 18, 2021 at 04:50:31PM +0300, Heikki Linnakangas wrote:
> > That didn't do what I wanted. It only printed the Heap2 records, not Heap,
> > even though I specified both. The reason is that if you specify multiple
> > --rmgr options, only the last one takes effect.
> >
> > I propose the attached to allow selecting multiple rmgrs, by giving multiple
> > --rmgr options. With that, it works the way I expected:
>
> The change and the patch look sensible to me.

+1.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-05-19 02:56:40 Re: Performance degradation of REFRESH MATERIALIZED VIEW
Previous Message Fujii Masao 2021-05-19 02:40:52 Re: wal stats questions