Re: Typo in README.barrier

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: dgrowleyml(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Typo in README.barrier
Date: 2021-05-17 04:45:09
Message-ID: 20210517.134509.1245356916585945681.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David,

>> Thanks for working on that. I had a look and wondered if it might be
>> better to go into slightly less details about the exact atomic
>> function to use. The wording there might lead you to believe you can
>> just call the atomic function on the non-atomic variable.
>>
>> It might be best just to leave the details about how exactly to use
>> atomics by just referencing port/atomics.h.
>>
>> Maybe something like the attached?
>
> Thanks. Agreed and your patch looks good to me.
>
>> I'm also a bit on the fence if this should be backpatched or not. The
>> reasons though maybe not is that it seems unlikely maybe people would
>> not be working in master if they're developing something new. On the
>> other side of the argument, 0ccebe779, which adjusts another README
>> was backpatched. I'm leaning towards backpatching.
>
> Me too. Let's backpatch.

Would you like to push the patch?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-05-17 04:46:29 Re: Typo in README.barrier
Previous Message Dilip Kumar 2021-05-17 04:39:50 Re: Race condition in recovery?