| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-15 00:10:17 |
| Message-ID: | 20210515001017.GU27406@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 14, 2021 at 07:50:13PM -0400, Alvaro Herrera wrote:
> +++ b/doc/src/sgml/config.sgml
> @@ -7643,7 +7643,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
> identifier to be computed. Note that an external module can
> alternatively be used if the in-core query identifier computation
> method is not acceptable. In this case, in-core computation
> - must be disabled. The default is <literal>off</literal>.
> + must be always disabled.
> + Valid values are <literal>off</literal> (always disabled),
> + <literal>on</literal> (always enabled) and <literal>auto</literal>,
> + which let modules such as <xref linkend="pgstatstatements"/>
> + automatically enable it.
> + The default is <literal>auto</literal>.
which lets
> +/* True when a module requests query IDs and they're set auto */
> +bool query_id_enabled = false;
Does "they're" mean the GUC compute_query_id ?
> +/*
> + * This should only be called if IsQueryIdEnabled()
> + * return true.
> + */
> JumbleState *
> JumbleQuery(Query *query, const char *querytext)
Should it Assert() that ?
Maybe you should update this too ?
doc/src/sgml/release-14.sgml
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-15 02:26:22 | Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Alvaro Herrera | 2021-05-14 23:50:13 | Re: compute_query_id and pg_stat_statements |