| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: AlterSubscription_refresh "wrconn" wrong variable? |
| Date: | 2021-05-06 20:58:28 |
| Message-ID: | 20210506205828.GA9515@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-May-06, Peter Smith wrote:
> PSA v3 of the patch. Same as before, but now also renames the global
> variable from "wrconn" to "lrep_worker_wrconn".
I think there are two patches here -- the changes to
AlterSubscription_refresh are a backpatchable bugfix, and the rest of it
can just be applied to master.
In my mind we make a bit of a distinction for global variables by using
CamelCase rather than undercore_separated_words. There are plenty that
violate that "rule" of course, but ISTM that makes them stand more and
it's less likely we've made this mistake. So I would name the variable
LogRepWALRcvConn or something like that. My €0.02.
--
Álvaro Herrera Valdivia, Chile
"Entristecido, Wutra (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-06 21:08:50 | Re: AlterSubscription_refresh "wrconn" wrong variable? |
| Previous Message | Álvaro Herrera | 2021-05-06 20:48:29 | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |