Re: v14 mechanical code beautification patches

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: v14 mechanical code beautification patches
Date: 2021-05-06 10:28:21
Message-ID: 20210506102821.GC14276@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 5, 2021 at 10:45:01PM -0400, Tom Lane wrote:
> I located the "current" versions of those files in libbind 6.0.
> (I put "current" in quotes because the file dates seem to be
> 2005-2008, so indeed development came to a stop a long time ago.)
>
> They are *very* different from what we have, though. Some of it
> is visibly cosmetic, but other parts have been rewritten quite a bit,
> so it's hard to tell if the functionality is identical.
>
> In the absence of a reason to think we have bugs that we need to
> fix, I'm not sure it's worth analyzing the differences in detail.
> I definitely wouldn't just adopt all the diffs blindly.
>
> In any case, that RELEASE_CHANGES item is clearly a dead letter
> now, so I'll go remove it.

OK, thanks for checking. I think there was some concern about IPv6
changes at the time we adopted this.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-05-06 10:35:30 Anti-critical-section assertion failure in mcxt.c reached by walsender
Previous Message Robert Haas 2021-05-06 10:24:11 Re: .ready and .done files considered harmful