Re: Why do we have perl and sed versions of Gen_dummy_probes?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Re: Why do we have perl and sed versions of Gen_dummy_probes?
Date: 2021-05-06 04:59:14
Message-ID: 20210506045914.p7iip4d2fqvi3oln@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-05-06 00:18:12 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > I understand why we don't want to rely on sed because of windows - but
> > it's far from obvious why we can't just use the .pl variant all the
> > time?
>
> Perl is not considered a hard build requirement on non-Windows.

Oops, forgot that.

> We could dodge that by shipping a pre-built dummy probes.h,
> but that doesn't really seem like a cleaner way than what's
> there now.

I tried to regenerate Gen_dummy_probes.pl using s2p - which doesn't seem
to exist for modern versions of perl anymore :(

> Also, as I read it, Gen_dummy_probes.sed is useful in any case as
> being the "source code" for Gen_dummy_probes.pl. You'd need some
> other form of documentation if you removed it.

:/

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2021-05-06 05:09:30 Re: Synchronous commit behavior during network outage
Previous Message Jeff Davis 2021-05-06 04:56:13 Re: [v15] ALTER TABLE ... SET ACCESS METHOD