Re: Enhanced error message to include hint messages for redundant options error

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Enhanced error message to include hint messages for redundant options error
Date: 2021-05-01 22:57:14
Message-ID: 20210501225714.GA5197@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-May-01, Bharath Rupireddy wrote:

> IMO, it's not good to change the function API just for showing up
> parse_position (which is there for cosmetic reasons I feel) in an error
> which actually has the option name clearly mentioned in the error message.

Why not? We've done it before, I'm sure you can find examples in the
git log. The function API is not that critical -- these functions are
mostly only called from ProcessUtility and friends.

--
Álvaro Herrera 39°49'30"S 73°17'W

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-05-02 03:16:07 Re: WIP: WAL prefetch (another approach)
Previous Message Michael Banck 2021-05-01 21:31:29 Re: Granting control of SUSET gucs to non-superusers