| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-05-01 17:24:09 |
| Message-ID: | 20210501172409.GA21641@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-May-01, vignesh C wrote:
> On Thu, Apr 29, 2021 at 10:44 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > On 2021-Apr-29, vignesh C wrote:
> >
> > > Thanks for the comments, please find the attached v3 patch which has
> > > the change for the first part.
> >
> > Looks good to me. I would only add parser_errposition() to the few
> > error sites missing that.
>
> I have not included parser_errposition as ParseState was not available
> for these errors.
Yeah, it's tough to do that in a few of those such as validator
functions, and I don't think we'd want to do that. However there are
some cases where we can easily add the parsestate as an argument -- for
example CreatePublication can get it in ProcessUtilitySlow and pass it
down to parse_publication_options; likewise for ExecuteDoStmt. I didn't
check other places.
--
Álvaro Herrera 39°49'30"S 73°17'W
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-05-01 17:55:44 | Re: Enhanced error message to include hint messages for redundant options error |
| Previous Message | Dmitry Dolgov | 2021-05-01 16:58:41 | Re: [PATCH] Identify LWLocks in tracepoints |