Re: Patch to allow pg_filedump to support reading of pg_filenode.map

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Richard Yen <richyen3(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, myon(at)debian(dot)org, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: Patch to allow pg_filedump to support reading of pg_filenode.map
Date: 2021-04-29 19:05:31
Message-ID: 20210429190531.GN27406@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I think you should be able to avoid crashing if passed a non-relmapper file.
Make sure not to loop over more mappings than exist in the relmapper file of
the given size.

I guess you should warn if the number of mappings is too large for the file's
size. And then "cap" the number of mappings to the maximum possible number.

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Yen 2021-04-29 19:39:57 Re: Patch to allow pg_filedump to support reading of pg_filenode.map
Previous Message Alvaro Herrera 2021-04-29 18:39:42 Re: Remove redundant variable from transformCreateStmt