| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-04-26 18:37:45 |
| Message-ID: | 20210426183745.4gd2s5qra6mlxfto@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-04-26 14:21:00 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> That's sounding like a pretty sane design, actually. Not sure about
> the shared-library-name-with-fixed-function-name detail, but certainly
> it seems to be useful to separate "I need a query-id" from the details
> of the ID calculation.
>
> Rather than a GUC per se for the ID provider, maybe we could have a
> function hook that defaults to pointing at the in-core computation,
> and then a module wanting to override that just gets into the hook.
I have a preference to determining the provider via GUC instead of a
hook because it is both easier to introspect and easier to configure.
If the provider is loaded via a hook, and the shared library is loaded
via shared_preload_libraries, one can't easily just turn that off in a
single session, but needs to restart or explicitly load a different
library (that can't already be loaded).
We also don't have any way to show what's hooking into a hook.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-04-26 18:43:21 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Tom Lane | 2021-04-26 18:21:00 | Re: compute_query_id and pg_stat_statements |