| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Kazutaka Onishi <onishi(at)heterodb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: TRUNCATE on foreign table |
| Date: | 2021-04-22 14:06:51 |
| Message-ID: | 20210422140651.GC7256@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 22, 2021 at 05:09:02PM +0530, Bharath Rupireddy wrote:
> > should it say "specified" instead of requested ?
> > Or should it say "requested the RESTART IDENTITY behavior" ?
> >
> > Also, I think it should say "..otherwise, the CONTINUE IDENTITY behavior was
> > requested".
>
> The original TRUNCATE document uses this - "When RESTART IDENTITY is specified"
>
> IMO the following looks better: "If restart_seqs is true, RESTART
> IDENTITY was specified in the original TRUNCATE command, otherwise
> CONTINUE IDENTITY was specified."
This suggests that one of the two options was "specified", but the user maybe
didn't specify either, which is why we used the "behavior" language - if
neither is "specified" then the default behavior is what was "requested".
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-04-22 14:27:34 | Re: decoupling table and index vacuum |
| Previous Message | Fujii Masao | 2021-04-22 13:42:14 | Re: wal stats questions |