Some doubious messages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Some doubious messages
Date: 2021-04-22 08:31:34
Message-ID: 20210422.173134.931507812550297086.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I found some doubious messages.

catalog.c:380, 404
> errdetail("OID candidates were checked \"%llu\" times, but no unused OID is yet found.",
> (errmsg("new OID has been assigned in relation \"%s\" after \"%llu\" retries",

It looks strange that %llu is enclosed by double-quotes and followed by
two spaces.

pg_inherits.c:542
> errhint("Use ALTER TABLE ... DETACH PARTITION ... FINALIZE to complete the pending detach operation")));
pg_type.c:991
> errhint("You can manually specify a multirange type name using the \"multirange_type_name\" attribute")));

A period is missing.

search_cte.c: 520, 527
> errmsg("search sequence column name and cycle mark column name are the same"),
> errmsg("search_sequence column name and cycle path column name are the same"),

The underscore in the latter seems like a typo.

partbounds.c: 2871, 2902
> errdetail("The new modulus %d is not a factor of %d, the modulus of existing partition \"%s\".",
> errdetail("The new modulus %d is not factor of %d, the modulus of existing partition \"%s\".",

The latter seems to be missing an article.

A possible fix is attched.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
fix_some_messages.patch text/x-patch 3.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-04-22 08:37:35 Re: Problems around compute_query_id
Previous Message Dave Page 2021-04-22 08:10:02 Re: PATCH: Add GSSAPI ccache_name option to libpq