From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Subject: | Re: Problems around compute_query_id |
Date: | 2021-04-20 16:59:10 |
Message-ID: | 20210420165910.GE30205@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Apr 15, 2021 at 03:43:59PM +0800, Julien Rouhaud wrote:
> On Mon, Apr 12, 2021 at 02:56:59PM +0800, Julien Rouhaud wrote:
> > I think we should simply document that %Q is not compatible with
> > log_statements.
>
> Hearing no objection I documented that limitation.
>
> >
> > > While making the feature run on some test server, I have noticed that
> > > %Q would log some garbage query ID for autovacuum workers that's kept
> > > around. That looks wrong.
> >
> > I've not been able to reproduce it, do you have some hint on how to do it?
> >
> > Maybe setting a zero queryid at the beginning of AutoVacWorkerMain() could fix
> > the problem?
>
> It turns out that the problem was simply that some process can inherit a
> PgBackendStatus for which a previous backend reported a queryid. For processes
> like autovacuum process, they will never report a new identifier so they
> reported the previous one. Resetting the field like the other ones in
> pgstat_bestart() fixes the problem for autovacuum and any similar process.
I slightly adjusted the patch and applied it. Thanks. I think this
closes all the open issues around query_id. :-)
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachment | Content-Type | Size |
---|---|---|
master.diff | text/x-diff | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2021-04-20 17:11:59 | Re: multi-install PostgresNode fails with older postgres versions |
Previous Message | Robert Haas | 2021-04-20 16:56:05 | Re: pg_amcheck option to install extension |