| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reduce the number of special cases to build contrib modules on windows |
| Date: | 2021-04-19 16:24:30 |
| Message-ID: | 20210419162430.GA27463@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm
> index ebb169e201..68606a296d 100644
> --- a/src/tools/msvc/MSBuildProject.pm
> +++ b/src/tools/msvc/MSBuildProject.pm
> @@ -310,11 +310,12 @@ sub WriteItemDefinitionGroup
> my $targetmachine =
> $self->{platform} eq 'Win32' ? 'MachineX86' : 'MachineX64';
>
> - my $includes = $self->{includes};
> - unless ($includes eq '' or $includes =~ /;$/)
> + my $includes = "";
> + foreach my $inc (@{ $self->{includes} })
> {
> - $includes .= ';';
> + $includes .= $inc . ";";
> }
Perl note: you can do this more easily as
my $includes = join ';', @{$self->{includes}};
$includes .= ';' unless $includes eq '';
--
Álvaro Herrera 39°49'30"S 73°17'W
Are you not unsure you want to delete Firefox?
[Not unsure] [Not not unsure] [Cancel]
http://smylers.hates-software.com/2008/01/03/566e45b2.html
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-04-19 16:28:16 | Re: Windows default locale vs initdb |
| Previous Message | Tom Lane | 2021-04-19 16:13:56 | Re: Commit 86dc90056 - Rework planning and execution of UPDATE and DELETE |