default_tablespace doc and partitioned rels

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: default_tablespace doc and partitioned rels
Date: 2021-04-16 14:31:35
Message-ID: 20210416143135.GI3315@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

commit 87259588d0ab0b8e742e30596afa7ae25caadb18
Author: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Date: Thu Apr 25 10:20:23 2019 -0400

Fix tablespace inheritance for partitioned rels

This doc change doesn't make sense to me:

+++ b/doc/src/sgml/config.sgml
@@ -7356,7 +7356,8 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
<para>
This variable specifies the default tablespace in which to create
objects (tables and indexes) when a <command>CREATE</command> command does
- not explicitly specify a tablespace.
+ not explicitly specify a tablespace. It also determines the tablespace
+ that a partitioned relation will direct future partitions to.
</para>

default_tablespace is a global GUC, so if a partitioned relation "directs"
partitions anywhere, it's not to the fallback value of the GUC, but to its
reltablespace, as this patch wrote in doc/src/sgml/ref/create_table.sgml:

+ the tablespace specified overrides <literal>default_tablespace</literal>
+ as the default tablespace to use for any newly created partitions when no
+ other tablespace is explicitly specified.

Maybe I'm misreading config.sgml somehow ?
I thought it would be more like this (but actually I think <default_tablespace>
shouldn't say anything at all):

+ ... It also determines the tablespace where new partitions are created,
+ if the parent, partitioned relation doesn't have a tablespace set.

--
Justin

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-04-16 15:32:01 Re: wrong units in ExplainPropertyFloat
Previous Message Tom Lane 2021-04-16 14:29:35 Re: Error when defining a set returning function